linux-kernel - Re: [PATCH] fs: sysfs: don't pass count == 0 to bin file readers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150521232615.GA7099@htj.duckdns.org>
Date:	Thu, 21 May 2015 19:26:15 -0400
From:	Tejun Heo <tj@...nel.org>
To:	Vladimir Zapolskiy <vz@...ia.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs: sysfs: don't pass count == 0 to bin file readers

Hello, Vladimir.

On Fri, May 22, 2015 at 02:04:31AM +0300, Vladimir Zapolskiy wrote:
> But "!size" is a special case,
> 
> 	if (!count || pos >= size)
> 		return 0;
> 
> seems to be incorrect in case of !size ===> (pos >= size) == true.

Hmmm... Why is that wrong tho?  If size is zero and pos is zero,
there's nothing to do, no?

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/