linux-kernel - Re: [PATCH v4 11/13] staging: lnet: o2iblnd: checkpatch.pl fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150522104946.GK4150@mwanda>
Date:	Fri, 22 May 2015 13:49:46 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Mike Shuey <shuey@...due.edu>
Cc:	oleg.drokin@...el.com, devel@...verdev.osuosl.org,
	gregkh@...uxfoundation.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org, HPDD-discuss@...1.01.org,
	lustre-deve@...ts.lustre.org
Subject: Re: [PATCH v4 11/13] staging: lnet: o2iblnd: checkpatch.pl fixes

On Thu, May 21, 2015 at 03:50:34PM -0400, Mike Shuey wrote:
> @@ -2758,7 +2763,7 @@ void kiblnd_shutdown(lnet_ni_t *ni)
>  		i = 2;
>  		while (atomic_read(&net->ibn_npeers) != 0) {
>  			i++;
> -			CDEBUG(((i & (-i)) == i) ? D_WARNING : D_NET, /* 2**n? */
> +			CDEBUG(((i & (-i)) == i) ? D_WARNING : D_NET,/* 2**n? */

The original was better.  I don't like this patch for the same reasons
that people complained about patch 10.  It does too many things as well.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/