linux-kernel - Re: [RFC PATCH v3 09/37] bpf tools: Open eBPF object file and do basic validation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150522172333.GE6609@krava.redhat.com>
Date:	Fri, 22 May 2015 19:23:33 +0200
From:	Jiri Olsa <jolsa@...hat.com>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	paulus@...ba.org, a.p.zijlstra@...llo.nl, mingo@...hat.com,
	acme@...nel.org, namhyung@...nel.org, jolsa@...nel.org,
	dsahern@...il.com, ast@...mgrid.com, daniel@...earbox.net,
	brendan.d.gregg@...il.com, masami.hiramatsu.pt@...achi.com,
	lizefan@...wei.com, linux-kernel@...r.kernel.org, pi3orama@....com
Subject: Re: [RFC PATCH v3 09/37] bpf tools: Open eBPF object file and do
 basic validation

On Sun, May 17, 2015 at 10:56:34AM +0000, Wang Nan wrote:

SNIP

> +				obj->path);
> +		err = -EINVAL;
> +		goto errout;
> +	}
> +	ep = &obj->elf.ehdr;
> +
> +	if ((ep->e_type != ET_REL) || (ep->e_machine != 0)) {
> +		pr_warning("%s is not an eBPF object file\n",
> +			obj->path);
> +		err = -EINVAL;
> +		goto errout;
> +	}
> +
>  	return 0;
> +errout:
> +	bpf_obj_clear_elf(obj);
> +	return err;
> +}
> +
> +struct bpf_object *bpf_open_object(const char *path)
> +{

another suggestion for the namespace.. Arnaldo forces us ;-)
to use the object name first plus '__(method name)' for
interface functions so that would be:

  bpf_object__open
  bpf_object__close

not sure we want to keep that standard in here though.. Arnaldo?

jirka


SNIP

> +void bpf_close_object(struct bpf_object *obj)
> +{
> +	if (!obj)
> +		return;
> +
> +	bpf_obj_clear_elf(obj);
> +
> +	if (obj->path)
> +		free(obj->path);
> +	free(obj);
>  }
> -- 
> 1.8.3.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/