linux-kernel - Re: [PATCH v7 6/7] clk: hi6220: Clock driver support for Hisilicon hi6220 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 23 May 2015 02:30:34 +0800
From:	Brent Wang <wangbintian@...il.com>
To:	Stephen Boyd <sboyd@...eaurora.org>
Cc:	Bintian <bintian.wang@...wei.com>,
	Mike Turquette <mturquette@...aro.org>,
	Zhangfei Gao <zhangfei.gao@...aro.org>,
	Xu Wei <xuwei5@...ilicon.com>,
	"xuejiancheng@...wei.com" <xuejiancheng@...wei.com>,
	Tomeu Vizoso <tomeu.vizoso@...labora.com>,
	"sledge.yanwei@...wei.com" <sledge.yanwei@...wei.com>,
	linux-clk@...r.kernel.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Arnd Bergmann <arnd@...db.de>,
	Will Deacon <will.deacon@....com>,
	Rob Herring <robh+dt@...nel.org>,
	Kevin Hilman <khilman@...aro.org>,
	Mark Rutland <mark.rutland@....com>,
	Catalin Marinas <catalin.marinas@....com>,
	Haojian Zhuang <haojian.zhuang@...aro.org>,
	linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
	Olof Johansson <olof@...om.net>,
	Haifeng Yan <yanhaifeng@...il.com>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Guodong Xu <guodong.xu@...aro.org>,
	Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>,
	Tyler Baker <tyler.baker@...aro.org>,
	Kevin Hilman <khilman@...nel.org>,
	"xuyiping@...ilicon.com" <xuyiping@...ilicon.com>,
	"wangbinghui@...ilicon.com" <wangbinghui@...ilicon.com>,
	"zhenwei.wang@...ilicon.com" <zhenwei.wang@...ilicon.com>,
	"victor.lixin@...ilicon.com" <victor.lixin@...ilicon.com>,
	"puck.chen@...ilicon.com" <puck.chen@...ilicon.com>,
	"dan.zhao@...ilicon.com" <dan.zhao@...ilicon.com>,
	"huxinwei@...wei.com" <huxinwei@...wei.com>,
	"z.liuxinliang@...wei.com" <z.liuxinliang@...wei.com>,
	"heyunlei@...wei.com" <heyunlei@...wei.com>,
	XinWei Kong <kong.kongxinwei@...ilicon.com>,
	"w.f@...wei.com" <w.f@...wei.com>,
	"Liguozhu (Kenneth)" <liguozhu@...ilicon.com>
Subject: Re: [PATCH v7 6/7] clk: hi6220: Clock driver support for Hisilicon
 hi6220 SoC

Hello Stephen,

2015-05-22 13:20 GMT+08:00 Bintian <bintian.wang@...wei.com>:
> Hello Stephen,
>
>
> On 2015/5/22 2:00, Stephen Boyd wrote:
>>
>> On 05/20/15 20:57, Bintian wrote:
>>>
>>>
>>>>
>>>>>
>>>>> +
>>>>> +static void __init hi6220_clk_sys_init(struct device_node *np)
>>>>> +{
>>>>> +    struct hisi_clock_data *clk_data;
>>>>> +
>>>>> +    clk_data = hisi_clk_init(np, HI6220_SYS_NR_CLKS);
>>>>> +    if (!clk_data)
>>>>> +        return;
>>>>> +
>>>>> +    hisi_clk_register_gate_sep(hi6220_separated_gate_clks_sys,
>>>>> +            ARRAY_SIZE(hi6220_separated_gate_clks_sys), clk_data);
>>>>> +
>>>>> +    hisi_clk_register_mux(hi6220_mux_clks_sys,
>>>>> +            ARRAY_SIZE(hi6220_mux_clks_sys), clk_data);
>>>>> +
>>>>> +    hi6220_clk_register_divider(hi6220_div_clks_sys,
>>>>> +            ARRAY_SIZE(hi6220_div_clks_sys), clk_data);
>>>>> +
>>>>> +    if (!clk_data_ao)
>>>>> +        return;
>>>>> +
>>>>> +    /* enable high speed clock on UART1 mux */
>>>>> +    clk_set_parent(clk_data->clk_data.clks[HI6220_UART1_SRC],
>>>>> +            clk_data_ao->clk_data.clks[HI6220_150M]);
>>>>
>>>>
>>>> Sorry I missed this one earlier. Can we do this clk_set_parent() through
>>>> assigned-parents instead?
>>>
>>> Uart1 has two clock parents in hi6220, and use "clk_tcxo" by default,
>>> we use uart1 to connect BT in HiKey, and switch to "clk_150m" for high
>>> speed mode of BT, but pl011 has no code to set clock rate or set clock
>>> parents operation, so it's a easy way to do that here.
>>
>>
>> Is pl011 the uart device? Does it have a node in DT somewhere? If it
>> does, then we could put the assigned-parents properties in that node so
>> that when the pl011 probes the uart1 clock has its parent set to
>> clk_150m. See the "Assigned clock parents and rates" section of
>> Documentation/devicetree/bindings/clock/clock-bindings.txt.
>>
> I will verify this.
Currently the "assigned-clock*" doesn't work for pl011 UART device
node, maybe we will
do some fix for its driver later or other modules.

How about keep the "clk_set_parent" in this patch now?

Thanks,

Bintian
>
> If it is OK, I will remove "clk_set_parent" from this patch.
>
> Thanks,
>
> Bintian
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/