linux-kernel - Re: [PATCH v2] x86: Stop relying on magic jmp behavior for early_idt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 22 May 2015 13:59:32 -0700
From:	"H. Peter Anvin" <hpa@...or.com>
To:	Andy Lutomirski <luto@...capital.net>,
	Ingo Molnar <mingo@...nel.org>
CC:	Andy Lutomirski <luto@...nel.org>, X86 ML <x86@...nel.org>,
	"H.J. Lu" <hjl.tools@...il.com>, Borislav Petkov <bp@...en8.de>,
	Jan Beulich <JBeulich@...e.com>,
	Binutils <binutils@...rceware.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] x86: Stop relying on magic jmp behavior for early_idt_handlers

On 05/21/2015 11:51 PM, Andy Lutomirski wrote:
>>>
>>>  #ifdef __KERNEL__
>>> +
>>> +/*
>>> + * early_idt_handlers is an array of entry points.  For simplicity, it's
>>> + * a real array.  We allocate nine bytes for each entry: two one-byte
>>> + * push instructions and a five-byte jump in the worst case.
>>> + */
>>> +#define EARLY_IDT_HANDLER_STRIDE 9
>>
>> So how come that two plus five equals nine? ;-)
> 
> A "one-byte push" would be pretty impressive :)
> 

Well, non-REX register pushes are just one byte.  However, these take an
immediate constant.

>>
>> Ditto for the 64-bit side.
> 
> Sounds good.  I'll do all this tomorrow and resend.
> 

Thank you!  Since I trust you, I'll send you this in advance:

Acked-by: H. Peter Anvin <hpa@...ux.intel.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/