linux-kernel - Re: [PATCH v1] power: max17042_battery: add HEALTH and TEMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150523181004.GC16004@earth>
Date:	Sat, 23 May 2015 20:10:05 +0200
From:	Sebastian Reichel <sre@...nel.org>
To:	Ramakrishna Pallala <ramakrishna.pallala@...el.com>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org,
	Krzysztof Kozlowski <k.kozlowski.k@...il.com>,
	MyungJoo Ham <myungjoo.ham@...sung.com>
Subject: Re: [PATCH v1] power: max17042_battery: add HEALTH and TEMP_*
 properties support

Hi,

On Tue, May 05, 2015 at 05:10:32AM +0530, Ramakrishna Pallala wrote:
> This patch adds the support for following battery properties
> to max17042 fuel gauge driver.
> 
> POWER_SUPPLY_PROP_TEMP_ALERT_MIN
> POWER_SUPPLY_PROP_TEMP_ALERT_MAX
> POWER_SUPPLY_PROP_TEMP_MIN
> POWER_SUPPLY_PROP_TEMP_MAX
> POWER_SUPPLY_PROP_HEALTH
> 
> Signed-off-by: Ramakrishna Pallala <ramakrishna.pallala@...el.com>
> Reviewed-by: Krzysztof Kozlowski <k.kozlowski.k@...il.com>

The patch does not work for me:

drivers/power/max17042_battery.c: In function ‘max17042_get_battery_health’:
drivers/power/max17042_battery.c:150:34: error: ‘MAX17042_VMAX_TOLERENCE’ undeclared (first use in this function)
  if (vbatt > chip->pdata->vmax + MAX17042_VMAX_TOLERENCE) {

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)