linux-kernel - Re: [char-misc-next 11/11] mei: revamp mei bus code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150525014629.GA5838@kroah.com>
Date:	Sun, 24 May 2015 18:46:29 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	"Winkler, Tomas" <tomas.winkler@...el.com>
Cc:	"arnd@...db.de" <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: Re: [char-misc-next 11/11] mei: revamp mei bus code

On Sun, May 24, 2015 at 09:29:41PM +0000, Winkler, Tomas wrote:
> > 
> > On Thu, May 07, 2015 at 03:54:08PM +0300, Tomas Winkler wrote:
> > > MEI bus was designed around nfc and was hard to extend.
> > > Instead of hard coded way of adding the devices on the mei bus
> > > we scan whole me client list and create a device for each
> > > eligible me client; currently we support only clients with
> > > single connection and fixed address clients.
> > > NFC radio name detection is run as a fixup routine
> > >
> > > Cc: Samuel Ortiz <sameo@...ux.intel.com>
> > > Signed-off-by: Tomas Winkler <tomas.winkler@...el.com>
> > > ---
> > >  drivers/misc/mei/Makefile    |   2 +-
> > >  drivers/misc/mei/bus-fixup.c | 306 ++++++++++++++
> > >  drivers/misc/mei/bus.c       | 975 ++++++++++++++++++++++++++++------------
> > ---
> > >  drivers/misc/mei/client.c    |   9 +-
> > >  drivers/misc/mei/init.c      |   5 +-
> > >  drivers/misc/mei/mei_dev.h   |  24 +-
> > >  drivers/misc/mei/nfc.c       | 414 ------------------
> > >  include/linux/mei_cl_bus.h   |  12 +
> > >  8 files changed, 968 insertions(+), 779 deletions(-)
> > >  create mode 100644 drivers/misc/mei/bus-fixup.c
> > >  delete mode 100644 drivers/misc/mei/nfc.c
> > 
> > This is a lot to do in just one patch.  Any chance you can split it up
> > into reviewable pieces?
> 
> I thought it would be harder to swallow but I'm not sure how to really 
> split this into working pieces w/o do some artificial steps which
>  I will have to validate again to keep the code bisectable. 

That's fine, that's your job to do :)

> What could be naturally factored out is already in separate  patches in this series. 
> The patch is maybe bigger because of code moves between files but what has really changes is just bus.c 

Then do the movement of functions around in one patch, and then the
logical changes in others.  Come on, you know how this whole thing
works, don't be lazy here...

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/