linux-kernel - RE: [char-misc-next 11/11] mei: revamp mei bus code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5B8DA87D05A7694D9FA63FD143655C1B3C4A0C0A@hasmsx109.ger.corp.intel.com>
Date:	Mon, 25 May 2015 04:40:50 +0000
From:	"Winkler, Tomas" <tomas.winkler@...el.com>
To:	Greg KH <gregkh@...uxfoundation.org>
CC:	"arnd@...db.de" <arnd@...db.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: RE: [char-misc-next 11/11] mei: revamp mei bus code


> > > This is a lot to do in just one patch.  Any chance you can split it up
> > > into reviewable pieces?
> >
> > I thought it would be harder to swallow but I'm not sure how to really
> > split this into working pieces w/o do some artificial steps which
> >  I will have to validate again to keep the code bisectable.
> 
> That's fine, that's your job to do :)

I'd would prefer to do something that wasn't' already done.

> 
> > What could be naturally factored out is already in separate  patches in this
> series.
> > The patch is maybe bigger because of code moves between files but what has
> really changes is just bus.c
> 
> Then do the movement of functions around in one patch, and then the
> logical changes in others.  Come on, you know how this whole thing
> works, don't be lazy here...
> 
Yep, I know how it works, but here it just didn't fit as the logical changes moved also the code.
Okay, I will split the code but allow me one comment, I think that you were lazy too  go into details and  you didn't send us to hell when we first submitted that bus code.
Tomas


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/