linux-kernel - Re: [PATCH] serial: 8250: remove return statements from void function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150525162306.GG9772@kroah.com>
Date:	Mon, 25 May 2015 09:23:06 -0700
From:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:	Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:	linux-serial@...r.kernel.org,
	Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
	Jiri Slaby <jslaby@...e.cz>,
	Peter Hurley <peter@...leysoftware.com>,
	Alan Cox <alan@...ux.intel.com>,
	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Ricardo Ribalda Delgado <ricardo.ribalda@...il.com>,
	Tony Lindgren <tony@...mide.com>,
	Yoshihiro YUNOMAE <yoshihiro.yunomae.ez@...achi.com>
Subject: Re: [PATCH] serial: 8250: remove return statements from void function

On Mon, May 25, 2015 at 10:53:03AM +0900, Masahiro Yamada wrote:
> 2015-05-25 4:46 GMT+09:00 Greg Kroah-Hartman <gregkh@...uxfoundation.org>:
> > On Mon, May 11, 2015 at 12:30:22PM +0900, Masahiro Yamada wrote:
> >> serial8250_set_mctrl() is a void type function.  Returning something
> >> does not look nice.
> >>
> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> >> ---
> >>
> >>  drivers/tty/serial/8250/8250_core.c | 5 +++--
> >>  1 file changed, 3 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/tty/serial/8250/8250_core.c b/drivers/tty/serial/8250/8250_core.c
> >> index 4882027..146f56c 100644
> >> --- a/drivers/tty/serial/8250/8250_core.c
> >> +++ b/drivers/tty/serial/8250/8250_core.c
> >> @@ -2019,8 +2019,9 @@ EXPORT_SYMBOL_GPL(serial8250_do_set_mctrl);
> >>  static void serial8250_set_mctrl(struct uart_port *port, unsigned int mctrl)
> >>  {
> >>       if (port->set_mctrl)
> >> -             return port->set_mctrl(port, mctrl);
> >> -     return serial8250_do_set_mctrl(port, mctrl);
> >> +             port->set_mctrl(port, mctrl);
> >> +     else
> >> +             serial8250_do_set_mctrl(port, mctrl);
> >>  }
> >
> > You just changed the logic here!
> 
> 
> Could you tell me why?
> 
> The logic still looks the same to me.

{sigh} you are right.  Sorry about that, I'll go dig up the original
patch and queue it up, this was my fault in reading the code
incorrectly.

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/