linux-kernel - Re: [PATCH] drivers:usb:fsl: Introduce FSL_USB2_PHY_UTMI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 25 May 2015 09:27:40 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Nikhil Badola <nikhil.badola@...escale.com>
Cc:	linux-kernel@...r.kernel.org,
	Ramneek Mehresh <ramneek.mehresh@...escale.com>
Subject: Re: [PATCH] drivers:usb:fsl: Introduce FSL_USB2_PHY_UTMI_DUAL macro

On Mon, May 25, 2015 at 02:57:34PM +0530, Nikhil Badola wrote:
> Introduce FSL_USB2_PHY_UTMI_DUAL macro for setting phy mode
> in SOCs such has T4240, T1040, T2080 which have utmi dual-phy
> 
> Signed-off-by: Ramneek Mehresh <ramneek.mehresh@...escale.com>
> Signed-off-by: Nikhil Badola <nikhil.badola@...escale.com>
> ---
>  drivers/usb/host/ehci-fsl.c      | 1 +
>  drivers/usb/host/fsl-mph-dr-of.c | 2 ++
>  include/linux/fsl_devices.h      | 1 +
>  3 files changed, 4 insertions(+)
> 
> diff --git a/drivers/usb/host/ehci-fsl.c b/drivers/usb/host/ehci-fsl.c
> index ab4eee3..1f0e4e0 100644
> --- a/drivers/usb/host/ehci-fsl.c
> +++ b/drivers/usb/host/ehci-fsl.c
> @@ -226,6 +226,7 @@ static int ehci_fsl_setup_phy(struct usb_hcd *hcd,
>  		portsc |= PORT_PTS_PTW;
>  		/* fall through */
>  	case FSL_USB2_PHY_UTMI:
> +	case FSL_USB2_PHY_UTMI_DUAL:
>  		if (pdata->have_sysif_regs && pdata->controller_ver) {
>  			/* controller version 1.6 or above */
>  			setbits32(non_ehci + FSL_SOC_USB_CTRL, UTMI_PHY_EN);
> diff --git a/drivers/usb/host/fsl-mph-dr-of.c b/drivers/usb/host/fsl-mph-dr-of.c
> index 7e325e9..ed39081 100644
> --- a/drivers/usb/host/fsl-mph-dr-of.c
> +++ b/drivers/usb/host/fsl-mph-dr-of.c
> @@ -69,6 +69,8 @@ static enum fsl_usb2_phy_modes determine_usb_phy(const char *phy_type)
>  		return FSL_USB2_PHY_UTMI;
>  	if (!strcasecmp(phy_type, "utmi_wide"))
>  		return FSL_USB2_PHY_UTMI_WIDE;
> +	if (!strcasecmp(phy_type, "utmi_dual"))
> +		return FSL_USB2_PHY_UTMI_DUAL;
>  	if (!strcasecmp(phy_type, "serial"))
>  		return FSL_USB2_PHY_SERIAL;
>  
> diff --git a/include/linux/fsl_devices.h b/include/linux/fsl_devices.h
> index a82296a..dd73fad 100644
> --- a/include/linux/fsl_devices.h
> +++ b/include/linux/fsl_devices.h
> @@ -64,6 +64,7 @@ enum fsl_usb2_phy_modes {
>  	FSL_USB2_PHY_UTMI,
>  	FSL_USB2_PHY_UTMI_WIDE,
>  	FSL_USB2_PHY_SERIAL,
> +	FSL_USB2_PHY_UTMI_DUAL,
>  };
>  

Don't you need to order these patches properly so that they are applied
in the correct way?  Please send these as a numbered series.

Also, please cc: the linux-usb mailing list, use
scripts/get_maintainer.pl for getting the correct people and mailing
lists.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/