linux-kernel - [PATCH RFC 00/13] Reduction globality of tasklist

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 25 May 2015 20:43:52 +0300
From:	Kirill Tkhai <ktkhai@...n.com>
To:	<linux-kernel@...r.kernel.org>
CC:	Oleg Nesterov <oleg@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...hat.com>,
	"Peter Zijlstra" <peterz@...radead.org>,
	Michal Hocko <mhocko@...e.cz>,
	"Rik van Riel" <riel@...hat.com>,
	Ionut Alexa <ionut.m.alexa@...il.com>,
	Peter Hurley <peter@...leysoftware.com>,
	Kirill Tkhai <tkhai@...dex.ru>
Subject: [PATCH RFC 00/13] Reduction globality of tasklist_lock

tasklist_lock is used for protection of many different task links.
These are place in init_task.tasks, parent-child relationship,
ptrace waiting, place in PID lists, SID/PGID leadership, proibition
of creation of new tasks etc. It's like gone BKL, and this badly
affects on granularity of a system.

The series aims to decrease its globality and introduces a new lock
for protection of task-task relationship. The lock's name is kin_lock.
Firstly, it protects parent-child relationship. Children sibling and
real_parent fields are protected by father's kin_lock. For transfering
a child from one parent to another you should take both fathers locks.

Child's parent is protected by ptracer's kin_lock. We should take
real_parent's and ptracer's locks to attach a child to ptracer. We
should use parent's lock to notify it about exiting. tasklist_lock
is not used in exit/wait notifications since now.

Also, real_parent's kin lock protects child's threads (is the child
is multithreaded) and multithread exiting. Task's sighand is protected
by it too. After all I nested tasklist_lock under kin_lock, so the lock
order now is
		kin_lock
		tasklist_lock
		sighand->lock

But. sighand, task_struct::tasks, thread group is still safe under
tasklist_lock. We may change __exit_signal() a little bit more, but
it wants additional changing of all tasklist_lock users and makes
the series bigger (plus 8-9 patches). I don't thing it's so necessary
right now. We may do that in the future if we want. All new users
shouldn't use tasklist_lock since now if possible (but mostly current
users may be easy rewritten using RCU. In a couple of place we will
have to use tasklist_lock to stop process creation).

Besides that, tasklist_lock still protects init_task.tasks list,
PID lists, SID and PGID leadership.

The series is in RFC format, because I didn't add exhaustive comments
to the code yet. Also, nesting of rwlock_t isn't reflected in lockdep,
and arch code still uses tasklist_lock (I hadn't analyze it yet).

I'd like to hear people's opinions about that. Welcome your comments/
ideas/suggestions.

Thanks!

---

Kirill Tkhai (13):
      exit: Clarify choice of new parent in forget_original_parent()
      rwlock_t: Implement double_write_{,un}lock()
      pid_ns: Implement rwlock_t pid_ns::cr_lock for locking child_reaper
      exit: Small refactoring mm_update_next_owner()
      fs: Refactoring in get_children_pid()
      core: Add rwlock_t task_list::kin_lock
      kin_lock: Implement helpers for kin_lock locking.
      core: Use kin_lock synchronizations between parent and child and for thread group
      exit: Use for_each_thread() in do_wait()
      exit: Add struct wait_opts's member held_lock and use it for tasklist_lock
      exit: Syncronize on kin_lock while do_notify_parent()
      exit: Delete write dependence on tasklist_lock in exit_notify()
      core: Nest tasklist_lock into task_struct::kin_lock

 fs/exec.c                     |   26 ++--
 fs/proc/array.c               |   28 ++--
 include/linux/init_task.h     |    1 
 include/linux/pid_namespace.h |    1 
 include/linux/sched.h         |  303 +++++++++++++++++++++++++++++++++++++++++
 include/linux/spinlock.h      |   19 +++
 kernel/exit.c                 |  178 +++++++++++++++++-------
 kernel/fork.c                 |   13 +-
 kernel/pid.c                  |   10 +
 kernel/pid_namespace.c        |    5 -
 kernel/ptrace.c               |   53 +++++--
 kernel/signal.c               |   20 +--
 kernel/sys.c                  |   19 +--
 mm/oom_kill.c                 |    9 +
 security/keys/keyctl.c        |    4 -
 security/selinux/hooks.c      |    4 -
 16 files changed, 570 insertions(+), 123 deletions(-)

--
Signed-off-by: Kirill Tkhai <ktkhai@...n.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/