linux-kernel - Re: [PATCH] livepatch: match function return value type with prototype

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5564219B.9040406@suse.cz>
Date:	Tue, 26 May 2015 09:32:43 +0200
From:	Jiri Slaby <jslaby@...e.cz>
To:	Minfei Huang <mnfhuang@...il.com>, Li Bin <huawei.libin@...wei.com>
CC:	Jiri Kosina <jkosina@...e.cz>,
	Nicholas Mc Guire <hofrat@...dl.org>,
	Josh Poimboeuf <jpoimboe@...hat.com>,
	Seth Jennings <sjenning@...hat.com>,
	Vojtech Pavlik <vojtech@...e.cz>,
	"live-patching@...r.kernel.org" <live-patching@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	xiexiuqi <xiexiuqi@...wei.com>,
	Hanjun Guo <guohanjun@...wei.com>,
	"mhuang@...hat.com" <mhuang@...hat.com>
Subject: Re: [PATCH] livepatch: match function return value type with prototype

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

On 05/26/2015, 06:46 AM, Minfei Huang wrote:
> On Tue, May 26, 2015 at 10:44 AM, Li Bin <huawei.libin@...wei.com>
> wrote:
>> The klp_is_module return type should be boolean.
>> 
>> Signed-off-by: Li Bin <huawei.libin@...wei.com> --- 
>> kernel/livepatch/core.c |    2 +- 1 files changed, 1
>> insertions(+), 1 deletions(-)
>> 
>> diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c 
>> index 284e269..30e9339 100644 --- a/kernel/livepatch/core.c +++
>> b/kernel/livepatch/core.c @@ -78,7 +78,7 @@ static struct klp_ops
>> *klp_find_ops(unsigned long old_addr)
>> 
>> static bool klp_is_module(struct klp_object *obj) { -
>> return obj->name; +       return !!obj->name; }
> 
> Hi, Bin.
> 
> Does compile blame the prototype before you convert it? If not, I
> think we do not need to fix it, since there are a lot of places in
> kernel where we return point value as boolean.

Yes, but the real reason is not that we use it on a lot of places, but
that it is standardized in ¶ 6.3.1.2:
When any scalar value is converted to _Bool, the result is 0 if the
value compares equal to 0; otherwise, the result is 1.

Along with the definition of scalar types:
Arithmetic types and pointer types are collectively called scalar types.

thanks,
- -- 
js
suse labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBCAAGBQJVZCGXAAoJEL0lsQQGtHBJMCEP/AufUwrMFZ7KTD/pWKpjpDlu
fP8eflJ7iBxGtHXe9PGOsthY4kd1mB+kCo+54N1gks9bbnWF6P302hck5zrBHBdH
/wbo7YXhbHicUNAXZUzxfDh3nkKmR96CIeqZhMp2H1UBzmGRKzd6kVSdBwlbJ0/W
ZNcWmiIaALdr7aMEw+qEExV35kUdbJaqUcHKC9in3qQtlzCVQbZ5mCqURe+61ZTL
9u/Sbf3vB+nJPzyC/8uSVAxF616PiPdgGvxRrrRrRH82JmRaVJFjsRJ1WeMNxOFt
s4gbNByNePmTG3SisqFFKQ6VJYyeEsxkeRKbvL2mW4IlzJjiWCbp6XHcv2/IzR9g
GdIu3Kgy5R0OBXTxMbb5VLVtDRZUYnD/HiOFVLdUiqI6HQ/MtdZGujnVhWAVGIse
BD8T+hTOQyt6Yk7evlEF+REOlAU8jvBvnq3PUfRlUjWso8w0giPx1Re6rQk4k39P
TmfIVrve79n2nR/OejeCAB3xBEDtFbKBg9I+5ONm1gogxz/+3o6mwfMGS8TSdNs9
l4Kl/dhQhSW3aOmrclUoOZpcAzfTJSNCepTFq6+hKIbKibtnKs63wkLnGyL+XZSE
dEOWBC/B5YNC9VVAm20U8jAtUS5gw3n0NpXFTxOi0nb62IGY+mT+D5pPylVn31Rq
H7FDzgpZ7+lyvx+FDqpv
=UzJg
-----END PGP SIGNATURE-----
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/