lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 26 May 2015 12:46:44 +0800 From: Minfei Huang <mnfhuang@...il.com> To: Li Bin <huawei.libin@...wei.com> Cc: Jiri Kosina <jkosina@...e.cz>, Nicholas Mc Guire <hofrat@...dl.org>, Josh Poimboeuf <jpoimboe@...hat.com>, Seth Jennings <sjenning@...hat.com>, Vojtech Pavlik <vojtech@...e.cz>, "live-patching@...r.kernel.org" <live-patching@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, xiexiuqi <xiexiuqi@...wei.com>, Hanjun Guo <guohanjun@...wei.com>, "mhuang@...hat.com" <mhuang@...hat.com> Subject: Re: [PATCH] livepatch: match function return value type with prototype On Tue, May 26, 2015 at 10:44 AM, Li Bin <huawei.libin@...wei.com> wrote: > The klp_is_module return type should be boolean. > > Signed-off-by: Li Bin <huawei.libin@...wei.com> > --- > kernel/livepatch/core.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c > index 284e269..30e9339 100644 > --- a/kernel/livepatch/core.c > +++ b/kernel/livepatch/core.c > @@ -78,7 +78,7 @@ static struct klp_ops *klp_find_ops(unsigned long old_addr) > > static bool klp_is_module(struct klp_object *obj) > { > - return obj->name; > + return !!obj->name; > } Hi, Bin. Does compile blame the prototype before you convert it? If not, I think we do not need to fix it, since there are a lot of places in kernel where we return point value as boolean. Thanks Minfei > > static bool klp_is_object_loaded(struct klp_object *obj) > -- > 1.7.1 > > > -- > To unsubscribe from this list: send the line "unsubscribe live-patching" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists