linux-kernel - Re: [PATCH] Revert "drm/i915: Force clean compilation with -Werror"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150526083956.GC20703@nuc-i3427.alporthouse.com>
Date:	Tue, 26 May 2015 09:39:56 +0100
From:	Chris Wilson <chris@...is-wilson.co.uk>
To:	Intel Graphics Development <intel-gfx@...ts.freedesktop.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Jani Nikula <jani.nikula@...el.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Daniel Vetter <daniel.vetter@...el.com>
Subject: Re: [PATCH] Revert "drm/i915: Force clean compilation with -Werror"

On Tue, May 26, 2015 at 10:20:26AM +0200, Daniel Vetter wrote:
> On Tue, May 26, 2015 at 08:57:13AM +0100, Chris Wilson wrote:
> > On Tue, May 26, 2015 at 07:47:22AM +0200, Daniel Vetter wrote:
> > > This reverts commit 118182e9d7d5afa0c7c10f568afb46ab78b462e9.
> > > 
> > > It's causing too much trouble when compile-testing for non-i915 folks.
> > 
> > What's the argument against using COMPILE_TEST as a proxy for detecting
> > all(yes|mod)config as in Damien's patch?
> 
> I also thought about random users bisecting who'll then also might trip
> over this. Figure that overall the benefit isn't good enough given the
> trouble this seems to have caused immediately. 0-day is pretty fast at
> screaming around about new compiler warnings anyway, for the cases where I
> miss them.

You haven't fixed the issue of breaking a bisect using allyesconfig
unless you modify history. Either way they need to do a couple of skips.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/