linux-kernel - Re: [PATCH 1/1 linux-next] video: fbdev: matrox: use swap() in matroxfb_decode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 May 2015 11:32:52 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Fabian Frederick <fabf@...net.be>, <linux-kernel@...r.kernel.org>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	<linux-fbdev@...r.kernel.org>
Subject: Re: [PATCH 1/1 linux-next] video: fbdev: matrox: use swap() in matroxfb_decode_var()



On 18/05/15 20:31, Fabian Frederick wrote:
> Use kernel.h macro definition.
> 
> Signed-off-by: Fabian Frederick <fabf@...net.be>
> ---
>  drivers/video/fbdev/matrox/matroxfb_base.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/fbdev/matrox/matroxfb_base.c
> index 62539ca..2ba4e54 100644
> --- a/drivers/video/fbdev/matrox/matroxfb_base.c
> +++ b/drivers/video/fbdev/matrox/matroxfb_base.c
> @@ -591,12 +591,8 @@ static int matroxfb_decode_var(const struct matrox_fb_info *minfo,
>  			unsigned int max_yres;
>  
>  			while (m1) {
> -				int t;
> -
>  				while (m2 >= m1) m2 -= m1;
> -				t = m1;
> -				m1 = m2;
> -				m2 = t;
> +				swap(m1, m2);
>  			}
>  			m2 = linelen * PAGE_SIZE / m2;
>  			*ydstorg = m2 = 0x400000 % m2;
> 

Thanks, I've queued this and the two other swap() patches for 4.2.

 Tomi


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)