linux-kernel - Re: [PATCH target] target: se_dev_check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 May 2015 11:02:08 +0200
From:	Bart Van Assche <bart.vanassche@...disk.com>
To:	Wu Fengguang <fengguang.wu@...el.com>,
	Christoph Hellwig <hch@....de>
CC:	<kbuild-all@...org>, Nicholas Bellinger <nab@...ux-iscsi.org>,
	<linux-scsi@...r.kernel.org>, <target-devel@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH target] target: se_dev_check_wce() can be static

On 05/26/15 10:13, kbuild test robot wrote:
>
> Signed-off-by: Fengguang Wu <fengguang.wu@...el.com>
> ---
>   target_core_device.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/target/target_core_device.c b/drivers/target/target_core_device.c
> index 2321884..1d309ad 100644
> --- a/drivers/target/target_core_device.c
> +++ b/drivers/target/target_core_device.c
> @@ -649,7 +649,7 @@ static u32 se_dev_align_max_sectors(u32 max_sectors, u32 block_size)
>   	return aligned_max_sectors;
>   }
>
> -bool se_dev_check_wce(struct se_device *dev)
> +static bool se_dev_check_wce(struct se_device *dev)
>   {
>   	bool wce = false;
>

Since patch "target: fix DPO and FUA bit checks" removed the last user 
of this function, please remove this function completely instead of 
declaring it static.

Thanks,

Bart.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/