linux-kernel - Re: [PATCH v6] serial: 8250_uniphier: add UniPhier serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1432650518.13900.72.camel@linux.intel.com>
Date:	Tue, 26 May 2015 15:28:38 +0100
From:	Alan Cox <alan@...ux.intel.com>
To:	"Shevchenko, Andriy" <andriy.shevchenko@...el.com>
Cc:	"yamada.masahiro@...ionext.com" <yamada.masahiro@...ionext.com>,
	"manabian@...il.com" <manabian@...il.com>,
	"bigeasy@...utronix.de" <bigeasy@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"alan@...rguk.ukuu.org.uk" <alan@...rguk.ukuu.org.uk>,
	"ricardo.ribalda@...il.com" <ricardo.ribalda@...il.com>,
	"blogic@...nwrt.org" <blogic@...nwrt.org>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"jslaby@...e.cz" <jslaby@...e.cz>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	"peter@...leysoftware.com" <peter@...leysoftware.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v6] serial: 8250_uniphier: add UniPhier serial driver

> > +
> > +#define UNIPHIER_UART_CHAR_FCR	3	/* Character / FIFO Control Register */
> > +#define UNIPHIER_UART_LCR_MCR	4	/* Line/Modem Control Register */
> > +#define   UNIPHIER_UART_LCR_SHIFT	8
> 
> Indentation problem, needs to be fixed.

If you are going to review a patch set at least look at the previous
reviews - the indentation was already discussed and is done that way to
show (as many drivers do) which are fields for which registers

> > +static unsigned int uniphier_serial_in(struct uart_port *p, int offset)
> > +{
> > +	int valshift = 0;
> 
> Perhaps unsigned int?

Why ? even if it mattered gcc is already realising that the value can
only be 0 or 8 and will be generating whatever works best for that.


Alan


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/