linux-kernel - Re: [PATCH v6] serial: 8250_uniphier: add UniPhier serial driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 26 May 2015 15:08:27 +0000
From:	"Shevchenko, Andriy" <andriy.shevchenko@...el.com>
To:	"alan@...ux.intel.com" <alan@...ux.intel.com>
CC:	"manabian@...il.com" <manabian@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"blogic@...nwrt.org" <blogic@...nwrt.org>,
	"bigeasy@...utronix.de" <bigeasy@...utronix.de>,
	"alan@...rguk.ukuu.org.uk" <alan@...rguk.ukuu.org.uk>,
	"ricardo.ribalda@...il.com" <ricardo.ribalda@...il.com>,
	"yamada.masahiro@...ionext.com" <yamada.masahiro@...ionext.com>,
	"linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
	"jslaby@...e.cz" <jslaby@...e.cz>,
	"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
	"peter@...leysoftware.com" <peter@...leysoftware.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH v6] serial: 8250_uniphier: add UniPhier serial driver

On Tue, 2015-05-26 at 15:28 +0100, Alan Cox wrote:
> > > +
> > > +#define UNIPHIER_UART_CHAR_FCR	3	/* Character / FIFO Control Register */
> > > +#define UNIPHIER_UART_LCR_MCR	4	/* Line/Modem Control Register */
> > > +#define   UNIPHIER_UART_LCR_SHIFT	8
> > 
> > Indentation problem, needs to be fixed.
> 
> If you are going to review a patch set at least look at the previous
> reviews - the indentation was already discussed and is done that way to
> show (as many drivers do) which are fields for which registers

This is not exactly the field, the way how to get the field.
In some cases it is even better to define something like
_LCR(x)  ((x) << 8)


> 
> > > +static unsigned int uniphier_serial_in(struct uart_port *p, int offset)
> > > +{
> > > +	int valshift = 0;
> > 
> > Perhaps unsigned int?
> 
> Why ? even if it mattered gcc is already realising that the value can
> only be 0 or 8 and will be generating whatever works best for that.

It's not about how gcc does, it's about what assumptions can be made
from the reading of the source code. I think if we do a counter of shift
value it would be nice to set an unsigned type explicitly.

-- 
Andy Shevchenko <andriy.shevchenko@...el.com>
Intel Finland Oy
---------------------------------------------------------------------
Intel Finland Oy
Registered Address: PL 281, 00181 Helsinki 
Business Identity Code: 0357606 - 4 
Domiciled in Helsinki 

This e-mail and any attachments may contain confidential material for
the sole use of the intended recipient(s). Any review or distribution
by others is strictly prohibited. If you are not the intended
recipient, please contact the sender and delete all copies.