linux-kernel - RE: [PATCH] RDMA/ocrdma: remove unneeded tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 26 May 2015 21:30:03 +0530
From:	Devesh Sharma <devesh.sharma@...gotech.com>
To:	Doug Ledford <dledford@...hat.com>,
	Laurent Navet <laurent.navet@...il.com>
Cc:	selvin.xavier@...lex.com, devesh.sharma@...lex.com,
	mitesh.ahuja@...lex.com, sean.hefty@...el.com,
	hal.rosenstock@...il.com, linux-rdma@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: RE: [PATCH] RDMA/ocrdma: remove unneeded tests

Although already applied, Thanks Laurent and Doug.

Acked-By: Devesh Sharma <devesh.sharma@...gotech.com>

> -----Original Message-----
> From: Doug Ledford [mailto:dledford@...hat.com]
> Sent: Tuesday, May 26, 2015 6:15 PM
> To: Laurent Navet
> Cc: selvin.xavier@...lex.com; devesh.sharma@...lex.com;
> mitesh.ahuja@...lex.com; sean.hefty@...el.com; hal.rosenstock@...il.com;
> linux-rdma@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] RDMA/ocrdma: remove unneeded tests
>
> On Thu, 2015-05-21 at 22:07 +0200, Laurent Navet wrote:
> > The same code is executed regardless status value, so these tests can
> > be removed.
> > Fix Coverity CID 1271151 and 1268788
>
> Thanks, applied for 4.2.
>
> > Signed-off-by: Laurent Navet <laurent.navet@...il.com>
> > ---
> >  drivers/infiniband/hw/ocrdma/ocrdma_hw.c | 6 ------
> >  1 file changed, 6 deletions(-)
> >
> > diff --git a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > index 0c9e959..e748090 100644
> > --- a/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > +++ b/drivers/infiniband/hw/ocrdma/ocrdma_hw.c
> > @@ -1960,9 +1960,6 @@ static int ocrdma_mbx_reg_mr_cont(struct
> ocrdma_dev *dev,
> >  		    upper_32_bits(hwmr->pbl_table[i + pbl_offset].pa);
> >  	}
> >  	status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
> > -	if (status)
> > -		goto mbx_err;
> > -mbx_err:
> >  	kfree(cmd);
> >  	return status;
> >  }
> > @@ -3044,9 +3041,6 @@ static int ocrdma_mbx_modify_eqd(struct
> ocrdma_dev *dev, struct ocrdma_eq *eq,
> >  				(eq[i].aic_obj.prev_eqd * 65)/100;
> >  	}
> >  	status = ocrdma_mbx_cmd(dev, (struct ocrdma_mqe *)cmd);
> > -	if (status)
> > -		goto mbx_err;
> > -mbx_err:
> >  	kfree(cmd);
> >  	return status;
> >  }
>
>
> --
> Doug Ledford <dledford@...hat.com>
>               GPG KeyID: 0E572FDD
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/