linux-kernel - Re: [PATCH 1/2] staging: gdm724x: Remove test for host endian

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150526155953.GK11588@mwanda>
Date:	Tue, 26 May 2015 18:59:53 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Jaime Arrocha <jarr@...neldev.net>
Cc:	gregkh@...uxfoundation.org, jonathankim@...semi.com,
	deanahn@...semi.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] staging: gdm724x: Remove test for host endian

On Tue, May 26, 2015 at 10:29:44AM -0500, Jaime Arrocha wrote:
> This is the first patch of two. Both patches perform a small clean up
> done to the section for host endian test. Instead of handling endianness
> internally, kernel functions were added for use.

> The second patch depends on the first one, it is just a small piece
> that is no longer needed.

This kind of dependencies are built in the the name patch 1/2 and 2/2.
We don't want this kind of meta commentary in the permanent changelog.
If it were needed then it would go under the --- cut off line.

And anyway, fold patch 1 & 2 together into one patch.  Do "one thing"
per patch instead of half a thing per patch.

> 
> Signed-off-by: Jaime Arrocha <jarr@...neldev.net>
> ---

<--- meta commentary goes here.

>  drivers/staging/gdm724x/gdm_endian.c |   52 +++++++++++++++-------------------
>  1 file changed, 23 insertions(+), 29 deletions(-)
> 
> diff --git a/drivers/staging/gdm724x/gdm_endian.c b/drivers/staging/gdm724x/gdm_endian.c
> index f6cc90a..609a433 100644
> --- a/drivers/staging/gdm724x/gdm_endian.c
> +++ b/drivers/staging/gdm724x/gdm_endian.c
> @@ -11,57 +11,51 @@
>   * GNU General Public License for more details.
>   */
>  
> -#include <linux/slab.h>

Is this related to endianness?

> +#include<asm/byteorder.h>
> +#ifdef __LITTLE_ENDIAN
> +#include<linux/byteorder/little_endian.h>
> +#else
> +#include<linux/byteorder/big_endian.h>
> +#endif

Why do we need this?  Also the spacing is wrong.

>  u16 gdm_cpu_to_dev16(struct gdm_endian *ed, u16 x)
>  {
> -	if (ed->dev_ed == ed->host_ed)
> -		return x;
> -
> -	return Endian16_Swap(x);
> +	if (ed->dev_ed == ENDIANNESS_LITTLE)
> +		return __cpu_to_le16(x);
> +	else
> +		return __cpu_to_be16(x);

Use cpu_to_le16() no underscore versions everywhere.  The other is for
code which is shared with usespace.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/