linux-kernel - Re: [PATCH] mfd: mediatek: Add GPIO sub module support into mfd.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150527092844.GV6325@pengutronix.de>
Date:	Wed, 27 May 2015 11:28:44 +0200
From:	Sascha Hauer <s.hauer@...gutronix.de>
To:	Hongzhou Yang <hongzhou.yang@...iatek.com>
Cc:	Lee Jones <lee.jones@...aro.org>,
	Matthias Brugger <matthias.bgg@...il.com>,
	dandan.he@...iatek.com, Samuel Ortiz <sameo@...ux.intel.com>,
	srv_heupstream@...iatek.com,
	Linus Walleij <linus.walleij@...aro.org>,
	linux-kernel@...r.kernel.org, linux-mediatek@...ts.infradead.org,
	Sascha Hauer <kernel@...gutronix.de>,
	yingjoe.chen@...iatek.com, eddie.huang@...iatek.com,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] mfd: mediatek: Add GPIO sub module support into mfd.

The subject lacks the mt6397 keyword. In the subject you say this is
about GPIO, but the patch seems to be about pinctrl.

On Wed, May 27, 2015 at 02:10:35AM -0700, Hongzhou Yang wrote:
> Base on Lee Jones' comment, change pinctrl subnode name.

This is the changelog, should be below the three --- so that git am
doesn't add this to the commit message

> 
> ---
> Register pinctrl subnode into 6397 mfd cell.

This is the commit message, should be above the three ---

> 
> Signed-off-by: Hongzhou Yang <hongzhou.yang@...iatek.com>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>  drivers/mfd/mt6397-core.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 09bc780..e50a9bc 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -34,6 +34,9 @@ static const struct mfd_cell mt6397_devs[] = {
>  	}, {
>  		.name = "mt6397-clk",
>  		.of_compatible = "mediatek,mt6397-clk",
> +	}, {
> +		.name = "mt6397-pinctrl",
> +		.of_compatible = "mediatek,mt6397-pinctrl",
>  	},
>  };
>  

Sascha

-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/