linux-kernel - Re: [PATCH] mfd: mediatek: Add GPIO sub module support into mfd.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150527103210.GI11677@x1>
Date:	Wed, 27 May 2015 11:32:10 +0100
From:	Lee Jones <lee.jones@...aro.org>
To:	Hongzhou Yang <hongzhou.yang@...iatek.com>
Cc:	Matthias Brugger <matthias.bgg@...il.com>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-mediatek@...ts.infradead.org, srv_heupstream@...iatek.com,
	Sascha Hauer <kernel@...gutronix.de>,
	yingjoe.chen@...iatek.com, eddie.huang@...iatek.com,
	dandan.he@...iatek.com, Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH] mfd: mediatek: Add GPIO sub module support into mfd.

On Wed, 27 May 2015, Hongzhou Yang wrote:

> Base on Lee Jones' comment, change pinctrl subnode name.
> 
> ---
> Register pinctrl subnode into 6397 mfd cell.

Sascha already mentioned what's wrong here, so I'll not labour the
point.

I'm feeling generous, I'll apply this and make the necessary changes
myself.  Please bear the points in mind for next time however.

Applied, thanks.

> Signed-off-by: Hongzhou Yang <hongzhou.yang@...iatek.com>
> Acked-by: Linus Walleij <linus.walleij@...aro.org>
> ---
>  drivers/mfd/mt6397-core.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 09bc780..e50a9bc 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -34,6 +34,9 @@ static const struct mfd_cell mt6397_devs[] = {
>  	}, {
>  		.name = "mt6397-clk",
>  		.of_compatible = "mediatek,mt6397-clk",
> +	}, {
> +		.name = "mt6397-pinctrl",
> +		.of_compatible = "mediatek,mt6397-pinctrl",
>  	},
>  };
>  

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/