linux-kernel - Re: [RFC PATCH v4 03/29] perf tools: Move linux/{list.h,poison.h} to tools/include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 27 May 2015 10:21:09 -0300
From:	Arnaldo Carvalho de Melo <acme@...nel.org>
To:	Wang Nan <wangnan0@...wei.com>
Cc:	paulus@...ba.org, a.p.zijlstra@...llo.nl, mingo@...hat.com,
	namhyung@...nel.org, jolsa@...nel.org, dsahern@...il.com,
	daniel@...earbox.net, brendan.d.gregg@...il.com,
	masami.hiramatsu.pt@...achi.com, lizefan@...wei.com,
	linux-kernel@...r.kernel.org, pi3orama@....com
Subject: Re: [RFC PATCH v4 03/29] perf tools: Move linux/{list.h,poison.h} to
 tools/include

Em Wed, May 27, 2015 at 10:15:12AM -0300, Arnaldo Carvalho de Melo escreveu:
> Em Wed, May 27, 2015 at 05:19:38AM +0000, Wang Nan escreveu:
> > This patch moves list.h from tools/perf/util/include/linux/list.h
> > to tools/include/linux/list.h to enable other libraries use macros in

> I'll apply this, but when doing these moves, one has to worry that these
> build targets continue working:
 
> [acme@...andy linux]$ make help | grep perf
>   perf-tar-src-pkg    - Build perf-4.1.0-rc2.tar source tarball
>   perf-targz-src-pkg  - Build perf-4.1.0-rc2.tar.gz source tarball

<SNIP>
 
> This, BTW, would have been caught if you had run:
> 
>   make -C tools/perf build-test
> 
> One of the last tests will do this packaging and building, alerting you that
> something is missing.
> 
> I am doing this for the two patches in this series that moves things to tools,

So, to summarize this further, and to run just this 'tarpkg' test, to speed up
testing for this specific case:

[acme@...andy linux]$ vim tools/perf/MANIFEST 
[acme@...andy linux]$ make -C tools/perf -f tests/make tarpkg
make: Entering directory `/home/acme/git/linux/tools/perf'
- tarpkg: ./tests/perf-targz-src-pkg .
make: Leaving directory `/home/acme/git/linux/tools/perf'
[acme@...andy linux]$ echo $?
0
[acme@...andy linux]$ git diff
diff --git a/tools/perf/MANIFEST b/tools/perf/MANIFEST
index a83cf75164e1..fce4a47347aa 100644
--- a/tools/perf/MANIFEST
+++ b/tools/perf/MANIFEST
@@ -40,6 +40,7 @@ tools/include/linux/bitops.h
 tools/include/linux/compiler.h
 tools/include/linux/export.h
 tools/include/linux/hash.h
+tools/include/linux/kernel.h
 tools/include/linux/log2.h
 tools/include/linux/types.h
 include/asm-generic/bitops/arch_hweight.h
[acme@...andy linux]$ git commit -a --amend

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/