linux-kernel - Re: [PATCH] staging: lustre: silence sparse warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1505271520490.2430@hadrien>
Date:	Wed, 27 May 2015 15:21:39 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Marcus Folkesson <marcus.folkesson@...il.com>
cc:	Oleg Drokin <oleg.drokin@...el.com>,
	Andreas Dilger <andreas.dilger@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Greg Donald <gdonald@...il.com>,
	Julia Lawall <Julia.Lawall@...6.fr>,
	Daniel Baluta <daniel.baluta@...el.com>,
	Lai Siyao <lai.siyao@...el.com>,
	Andriy Skulysh <Andriy_Skulysh@...atex.com>,
	Joe Perches <joe@...ches.com>, HPDD-discuss@...1.01.org,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: lustre: silence sparse warnings

Maybe the explanation should more like "Make functions that are not used
in other files static", rather than just silencing a tool.

julia

On Wed, 27 May 2015, Marcus Folkesson wrote:

> Warnings reported by sparse:
> drivers/staging/lustre/lustre/ptlrpc/pinger.c:94:5: warning: symbol 'ptlrpc_ping' was not declared. Should it be static?
> drivers/staging/lustre/lustre/ptlrpc/pinger.c:113:6: warning: symbol 'ptlrpc_update_next_ping' was not declared. Should it be static?
> drivers/staging/lustre/lustre/ptlrpc/pinger.c:144:6: warning: symbol 'pinger_check_timeout' was not declared. Should it be static?
> drivers/staging/lustre/lustre/ptlrpc/pinger.c:425:21: warning: symbol 'ptlrpc_new_timeout' was not declared. Should it be static?
> drivers/staging/lustre/lustre/ptlrpc/pinger.c:551:1: warning: symbol 'pet_list' was not declared. Should it be static?
>
> Signed-off-by: Marcus Folkesson <marcus.folkesson@...il.com>
> ---
>  drivers/staging/lustre/lustre/ptlrpc/pinger.c | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/ptlrpc/pinger.c b/drivers/staging/lustre/lustre/ptlrpc/pinger.c
> index 5abb91c..ff9d904 100644
> --- a/drivers/staging/lustre/lustre/ptlrpc/pinger.c
> +++ b/drivers/staging/lustre/lustre/ptlrpc/pinger.c
> @@ -91,7 +91,7 @@ int ptlrpc_obd_ping(struct obd_device *obd)
>  }
>  EXPORT_SYMBOL(ptlrpc_obd_ping);
>
> -int ptlrpc_ping(struct obd_import *imp)
> +static int ptlrpc_ping(struct obd_import *imp)
>  {
>  	struct ptlrpc_request *req;
>
> @@ -110,7 +110,7 @@ int ptlrpc_ping(struct obd_import *imp)
>  	return 0;
>  }
>
> -void ptlrpc_update_next_ping(struct obd_import *imp, int soon)
> +static void ptlrpc_update_next_ping(struct obd_import *imp, int soon)
>  {
>  	int time = soon ? PING_INTERVAL_SHORT : PING_INTERVAL;
>  	if (imp->imp_state == LUSTRE_IMP_DISCON) {
> @@ -141,7 +141,7 @@ static inline int ptlrpc_next_reconnect(struct obd_import *imp)
>  		return cfs_time_shift(obd_timeout);
>  }
>
> -long pinger_check_timeout(unsigned long time)
> +static long pinger_check_timeout(unsigned long time)
>  {
>  	struct timeout_item *item;
>  	unsigned long timeout = PING_INTERVAL;
> @@ -422,7 +422,7 @@ EXPORT_SYMBOL(ptlrpc_pinger_del_import);
>   * Register a timeout callback to the pinger list, and the callback will
>   * be called when timeout happens.
>   */
> -struct timeout_item *ptlrpc_new_timeout(int time, enum timeout_event event,
> +static struct timeout_item *ptlrpc_new_timeout(int time, enum timeout_event event,
>  					timeout_cb_t cb, void *data)
>  {
>  	struct timeout_item *ti;
> @@ -548,7 +548,7 @@ void ptlrpc_pinger_wake_up(void)
>  static int pet_refcount;
>  static int	       pet_state;
>  static wait_queue_head_t       pet_waitq;
> -LIST_HEAD(pet_list);
> +static LIST_HEAD(pet_list);
>  static DEFINE_SPINLOCK(pet_lock);
>
>  int ping_evictor_wake(struct obd_export *exp)
> --
> 1.9.1
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/