linux-kernel - Re: [PATCH v2] spmi-pmic-arb: add irq tracepoints to the pmic-arb driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150527123018.2d61d3fb@gandalf.local.home>
Date:	Wed, 27 May 2015 12:30:18 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	"Ankit Gupta" <ankgupta@...eaurora.org>
Cc:	gavidov@...eaurora.org, sdharia@...eaurora.org,
	ivan.ivanov@...aro.org, svarbanov@...sol.com,
	linux-arm-msm@...r.kernel.org, gregkh@...uxfoundation.org,
	sboyd@...eaurora.org, collinsd@...eaurora.org,
	osvaldob@...eaurora.org, linux-kernel@...r.kernel.org,
	mlocke@...eaurora.org, galak@...eaurora.org, agross@...eaurora.org
Subject: Re: [PATCH v2] spmi-pmic-arb: add irq tracepoints to the pmic-arb
 driver

On Wed, 27 May 2015 10:21:10 -0600
"Ankit Gupta" <ankgupta@...eaurora.org> wrote:

> > The spmi-pmic-arb is also an interrupt controller. It gets a
> > single aggregate irq and disseminates it to individual
> > pmic-peripheral drivers. Each pmic-peripheral has a unique apid
> > number, and can have multiple interrupt capable functions.
> > The registered apid range shows the lowest and highest apid
> > numbers of pmic-peripheral drivers which request irqs. Pid is
> > the base address of that peripheral. For performance measurement,
> > tracepoints are added at the beginning of the aggregate irq and
> > at the end of the individual pmic-peripheral irqs.
> >
> > Following is a list showing the new tracepoint events:
> >
> > spmi_pmic_arb_aggregate_irq_start: aggregate irq number and registered
> > 				   apid range.
> >
> > spmi_pmic_arb_apid_irq_end: apid, irq, func_num, sid and pid.
> >
> > SPMI Interrupts tracepoints can be enabled like:
> >
> > echo 1 >/sys/kernel/debug/tracing/events/spmi-pmic-arb/enable
> >
> > and will dump messages that can be viewed in
> > /sys/kernel/debug/tracing/trace that look like:
> > ... spmi_pmic_arb_aggregate_irq_start: irq=150 registered apid
> > range=(3,189)
> > ... spmi_pmic_arb_apid_irq_end: apid=3 irq=1 func_num=0 sid=0 pid=0x8
> >
> > Suggested-by: Sagar Dharia <sdharia@...eaurora.org>
> > Signed-off-by: Gilad Avidov <gavidov@...eaurora.org>
> > Signed-off-by: Ankit Gupta <ankgupta@...eaurora.org>
> > ---
> 
> ---
> Changes since V1:
> - pass ppid from driver to evaluate pid and sid in trace file itself.
> - type of apid range change from int to u16 as max range can be 512.
> - type of func_num change from int to u8, as max it can be 8.
> ---
> 

Tracing part looks fine to me.

Acked-by: Steven Rostedt <rostedt@...dmis.org>

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/