linux-kernel - Re: [PATCH 1/3] X.509: Fix certificate gathering again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1432801998.3499.23.camel@infradead.org>
Date:	Thu, 28 May 2015 09:33:18 +0100
From:	David Woodhouse <dwmw2@...radead.org>
To:	Michal Marek <mmarek@...e.cz>
Cc:	David Howells <dhowells@...hat.com>, torvalds@...ux-foundation.org,
	aricart@...nix.com, linux-kernel@...r.kernel.org,
	sedat.dilek@...il.com, keyrings@...ux-nfs.org,
	rusty@...tcorp.com.au, linux-security-module@...r.kernel.org,
	james.l.morris@...cle.com
Subject: Re: [PATCH 1/3] X.509: Fix certificate gathering again

On Thu, 2015-05-28 at 13:18 +0800, Michal Marek wrote:
> 
> The only issue is that the makefile expressions are a bit hairy. For
> starters, we already have definitions for $(quote) and $(space) in
> kbuild. I'll have a closer look at the config_filename macro and try to
> simplify it somehow. But it's just cosmetics, the patch can be merged as
> is for now.

I've actually changed my mind about the 'awk | base64 -d' bit. The error
handling is too poor. I'd like to do that in C with a variant of the
existing extract_cert tool, and make sure we have proper X.509
certificates and error handling/reporting.

I'll fix that, but probably not this week while I'm ostensibly on
honeymoon and not answering emails like this one...

(If anyone else wants to beat me to it, you probably just need to make
extract_cert.c loop on extracting the certs from the file/BIO, but do
make sure it tolerates only *one* in the existing 'find signer cert'
mode.)

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@...el.com                              Intel Corporation

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/