linux-kernel - Re: [PATCH] staging: gdm72xx: remove unneeded test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.10.1505281031250.2464@hadrien>
Date:	Thu, 28 May 2015 10:33:17 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Joe Perches <joe@...ches.com>
cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	Laurent Navet <laurent.navet@...il.com>,
	devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gdm72xx: remove unneeded test

On Thu, 28 May 2015, Joe Perches wrote:

> On Thu, 2015-05-28 at 10:14 +0300, Dan Carpenter wrote:
> > On Wed, May 27, 2015 at 01:30:08PM -0700, Joe Perches wrote:
> > > Perhaps all of the uses like:
> > > 	goto <foo>;
> > > <foo>:
> > >
> > > could be modified.  There are ~150 in the kernel.
> >
> > Joe, these are a kind of style.  You're just directing a newbie into a
> > hornets nest.  Laurant, don't do listen to Joe unless you like getting
> > flamed.
>
> Hey Dan.
>
> I didn't direct anyone to do anything, but that's
> why I added Julia to cc's.
>
> Anyway, I think these are very equivalent style to
> the repeated:
>
> 	ret = foo();
> 	if (ret < 0)
> 		return ret;
> ...
> 	ret = bar();
> 	if (ret < 0)
> 		return ret;
>
> 	return ret;
>
> and people seem to prefer changing those.

Maybe if there is a whole sequence of them, it it is reasonable to keep
them.  But if there is just one, it seems complicated for nothing.  In the
big scheme of things, though, there are probably better things one could
do than changing all of them.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/