[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1432802477.2846.209.camel@perches.com>
Date: Thu, 28 May 2015 01:41:17 -0700
From: Joe Perches <joe@...ches.com>
To: Julia Lawall <julia.lawall@...6.fr>
Cc: Dan Carpenter <dan.carpenter@...cle.com>,
Laurent Navet <laurent.navet@...il.com>,
devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: gdm72xx: remove unneeded test
On Thu, 2015-05-28 at 10:33 +0200, Julia Lawall wrote:
> On Thu, 28 May 2015, Joe Perches wrote:
> I think these are very equivalent style to
> > the repeated:
> >
> > ret = foo();
> > if (ret < 0)
> > return ret;
> > ...
> > ret = bar();
> > if (ret < 0)
> > return ret;
> >
> > return ret;
> >
> > and people seem to prefer changing those.
>
> Maybe if there is a whole sequence of them, it it is reasonable to keep
> them. But if there is just one, it seems complicated for nothing.
Agree with that.
https://lkml.org/lkml/2015/1/2/321
> In the
> big scheme of things, though, there are probably better things one could
> do than changing all of them.
Agree with that too.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists