linux-kernel - Re: [PATCH] ASoC: wm_adsp: Dump DSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150528142431.GA19558@opensource.wolfsonmicro.com>
Date:	Thu, 28 May 2015 15:24:39 +0100
From:	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
To:	Mark Brown <broonie@...nel.org>
Cc:	patches@...nsource.wolfsonmicro.com, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: wm_adsp: Dump DSP_SCRATCH1 on DSP shutdown

On Thu, May 28, 2015 at 02:57:51PM +0100, Mark Brown wrote:
> On Thu, May 28, 2015 at 02:45:14PM +0100, Richard Fitzgerald wrote:
> 
> > +#define ADSP2_SCRATCH0        0x40
> > +#define ADSP2_SCRATCH1        0x41
> > +#define ADSP2_SCRATCH2        0x42
> > +#define ADSP2_SCRATCH3        0x43
> 
> May as well dump the other scratches while you're at it?
> 

Fair enough

> > +	unsigned int scratch1 = 0xFFFFFFFF;
> 
> Why is this being initialized?
> 

It was done a way to avoid having two shutdown messages to cover
the rare case that we somehow failed to read the register value, since
the firmware could never write this value (it as 31 bits set).


> > -		adsp_dbg(dsp, "Shutdown complete\n");
> > +		adsp_info(dsp, "Shutdown complete (SCRATCH1:0x%x)\n", scratch1);
> 
> That seems a bit loud for a diagnostic message, why raise the severity?

It's a diagnostic of the firmware, not the driver, and we can't assume that
people trying to use a firmware have the ability to build and flash a kernel
with a debug version of the driver

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/