linux-kernel - Re: [PATCH] ASoC: wm_adsp: Dump DSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150528143724.GY21577@sirena.org.uk>
Date:	Thu, 28 May 2015 15:37:24 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
Cc:	patches@...nsource.wolfsonmicro.com, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: wm_adsp: Dump DSP_SCRATCH1 on DSP shutdown

On Thu, May 28, 2015 at 03:24:39PM +0100, Richard Fitzgerald wrote:
> On Thu, May 28, 2015 at 02:57:51PM +0100, Mark Brown wrote:

> > > -		adsp_dbg(dsp, "Shutdown complete\n");
> > > +		adsp_info(dsp, "Shutdown complete (SCRATCH1:0x%x)\n", scratch1);

> > That seems a bit loud for a diagnostic message, why raise the severity?

> It's a diagnostic of the firmware, not the driver, and we can't assume that
> people trying to use a firmware have the ability to build and flash a kernel
> with a debug version of the driver

The default is that dev_dbg() is available in dmesg but not on the
console which usually seems like a reasonable balance for this sort of
thing - it's there if people want it but not included in the default
logging.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)