linux-kernel - Re: [PATCH] staging: ft1000: warning removal: extern functions to static ones

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150528162554.GC23837@kroah.com>
Date:	Thu, 28 May 2015 09:25:54 -0700
From:	Greg KH <greg@...ah.com>
To:	Xavier Roche <roche@...rack.com>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: ft1000: warning removal: extern functions to
 static ones

On Thu, May 28, 2015 at 05:24:56PM +0200, Xavier Roche wrote:
> Local functions not used in other modules should be static, not extern.
> (patch checked against linux-next and staging)

This line shouldn't be here, it should just be "implied" :)

> Signed-off-by: Xavier Roche <roche@...rack.com>
> ---
>  drivers/staging/ft1000/ft1000-pcmcia/ft1000_dnld.c | 24 +++++++++++-----------
>  1 file changed, 12 insertions(+), 12 deletions(-)

In the future, always use scripts/get_maintainer.pl to determine who to
send patches to please.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/