linux-kernel - Re: [PATCH] ASoC: wm_adsp: Dump DSP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150528192335.GD21577@sirena.org.uk>
Date:	Thu, 28 May 2015 20:23:35 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
Cc:	patches@...nsource.wolfsonmicro.com, alsa-devel@...a-project.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ASoC: wm_adsp: Dump DSP_SCRATCH1 on DSP shutdown

On Thu, May 28, 2015 at 05:13:13PM +0100, Richard Fitzgerald wrote:
> On Thu, May 28, 2015 at 03:37:24PM +0100, Mark Brown wrote:

> > The default is that dev_dbg() is available in dmesg but not on the
> > console which usually seems like a reasonable balance for this sort of
> > thing - it's there if people want it but not included in the default
> > logging.

> What you're describing seems to be the default for dev_info().
> For me I don't get any dev_dbg() output in the dmesg log unless the source
> file has a #define DEBUG at the top.

Interesting...  the dev_dbg default appears to have been changed at some
point, possibly with the addition of dynamic debug (which I tend to have
on in my configurations and is common for distros and so on).  The info
default is overridden by a lot of distros.  In any case, it's still the
way we generally do debug - doing this on every DSP stop does seem quite
chatty from a system point of view (and yes, some of the existing
logging in the driver does seem a bit enthusiastic here too in
retrospect, IIRC at the time request_firmware() was chatty too but that
has been fixed).

Users will typically have the option to get this via ftrace as well (we
have trace points for register read), and you might also want to
consider the option of exporting the value via a sysfs file so people
can grab the latest value whenever they like.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)