linux-kernel - Re: LOCKDEP warning due to ext_devt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <55668C45.3060700@fb.com>
Date:	Wed, 27 May 2015 21:32:21 -0600
From:	Jens Axboe <axboe@...com>
To:	NeilBrown <neilb@...e.de>, Keith Busch <keith.busch@...el.com>
CC:	lkml <linux-kernel@...r.kernel.org>
Subject: Re: LOCKDEP warning due to ext_devt_lock

On 05/27/2015 08:32 PM, NeilBrown wrote:
>
> Hi Keith,
>   I'm getting lockdep warning around use of ext_devt_lock.
>
> [11428.266019] inconsistent {SOFTIRQ-ON-W} -> {IN-SOFTIRQ-W} usage.
>
>   As you say in
>      2da78092dda1 ("block: Fix dev_t minor allocation lifetime")
> ext_devt_lock can be taken from call_rcu's soft-irq.
> I think that means it should always use the _irq verion of spinlock.

Wouldn't spin_lock_bh() and friends suffice then?

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/