linux-kernel - Re: [RFC v3 42/45] nfs: Add richacl support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHQdGtQyEH9V_XJaQQgPkKGJLy__D0J6cmAHASeEXCZkCCrBjg@mail.gmail.com>
Date:	Thu, 28 May 2015 19:06:17 -0400
From:	Trond Myklebust <trond.myklebust@...marydata.com>
To:	Andreas Gruenbacher <andreas.gruenbacher@...il.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux FS-devel Mailing List <linux-fsdevel@...r.kernel.org>,
	Linux NFS Mailing List <linux-nfs@...r.kernel.org>
Subject: Re: [RFC v3 42/45] nfs: Add richacl support

On Fri, Apr 24, 2015 at 7:04 AM, Andreas Gruenbacher
<andreas.gruenbacher@...il.com> wrote:
> Changes nfs to support the "system.richacl" xattr instead of "system.nfs4_acl".
>

NACK.

You may declare a userspace syscall ABI that is more than 10 years old
to be deprecated, but you are not allowed to remove it.

Furthermore, your entire premise of using the mode bits and the acl at
the same time is flawed; you are at best trying to set up a private
protocol to pass your mask info. According to RFC7530, Section
6.4.1.3, if you try to send the mode bits and ACL in the same SETATTR,
then the result should be to apply the mode first, then override all
the lower mode bits (i.e. everything except the suid, sgid and ) with
the ACL...

Trond
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/