linux-kernel - Re: [PATCH] fixup! dmaengine: pxa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1617548760.717381111.1432891749082.JavaMail.root@zimbra1-e1.priv.proxad.net>
Date:	Fri, 29 May 2015 11:29:09 +0200 (CEST)
From:	robert.jarzmik@...e.fr
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information

----- Mail original -----
De: "Vinod Koul" <vinod.koul@...el.com>
À: "Robert Jarzmik" <robert.jarzmik@...e.fr>

On Wed, May 27, 2015 at 11:23:40PM +0200, Robert Jarzmik wrote:
> This fixes the following error:
> drivers/dma/pxa_dma.c: In function ‘dbg_show_requester_chan’:
> drivers/dma/pxa_dma.c:192:2: error: void value not ignored as it ought to be
>   pos += seq_printf(s, "DMA channel %d requester :\n", phy->idx);
> Applied now.
Thanks.

> but not pleased that you sent broken code. Sending stuff that
> compiles is basic step
You should know me better by now. I told you I compiled *and* tested.

And with a a bit closer look check this commit, especially the date :
commit 0bac33653b06a5f80a5c04e275eb33db9493b85a
Author: Joe Perches <joe@...ches.com>
Date:   Sat May 23 12:00:38 2015 +1000

    fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void

Cheers.

--
Robert
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/