linux-kernel - Re: [PATCH] fixup! dmaengine: pxa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1432893073.29807.15.camel@perches.com>
Date:	Fri, 29 May 2015 02:51:13 -0700
From:	Joe Perches <joe@...ches.com>
To:	robert.jarzmik@...e.fr
Cc:	Vinod Koul <vinod.koul@...el.com>, Daniel Mack <daniel@...que.org>,
	Haojian Zhuang <haojian.zhuang@...il.com>,
	linux-arm-kernel@...ts.infradead.org, dmaengine@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fixup! dmaengine: pxa_dma: add debug information

On Fri, 2015-05-29 at 11:29 +0200, robert.jarzmik@...e.fr wrote:
> ----- Mail original -----
> De: "Vinod Koul" <vinod.koul@...el.com>
> On Wed, May 27, 2015 at 11:23:40PM +0200, Robert Jarzmik wrote:
> > This fixes the following error:
[]
> And with a a bit closer look check this commit, especially the date :
> commit 0bac33653b06a5f80a5c04e275eb33db9493b85a
> Author: Joe Perches <joe@...ches.com>
> Date:   Sat May 23 12:00:38 2015 +1000
> 
>     fs/seq_file: convert int seq_vprint/seq_printf/etc... returns to void

Hello Robert.

The return value of that dbg_show_requester_chan function
was incorrect and the increment of pos was an example of
why the seq_printf return value was changed to void.

It was a pretty common error and easy to understand given
the expectation that seq_printf should work like printf.

It's a pity it bit you. but this type of patch collision
should be a bit more difficult to reoccur in the future.

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/