linux-kernel - Re: [PATCH] kernel:user_namespace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5567AE52.6040000@infradead.org>
Date:	Thu, 28 May 2015 17:09:54 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Shailendra Verma <shailendra.capricorn@...il.com>
CC:	Andy Lutomirski <luto@...capital.net>,
	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Fabian Frederick <fabf@...net.be>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel:user_namespace - Fix for typos in comments.

On 05/23/15 11:02, Eric W. Biederman wrote:
> Shailendra Verma <shailendra.capricorn@...il.com> writes:
> 
>> Signed-off-by: Shailendra Verma <shailendra.capricorn@...il.com>
>> ---
>>  kernel/user_namespace.c |    8 ++++----
>>  1 file changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/kernel/user_namespace.c b/kernel/user_namespace.c
>> index 4109f83..02a1197 100644
>> --- a/kernel/user_namespace.c
>> +++ b/kernel/user_namespace.c
>> @@ -69,7 +69,7 @@ int create_user_ns(struct cred *new)
>>  	/*
>>  	 * Verify that we can not violate the policy of which files
>>  	 * may be accessed that is specified by the root directory,
>> -	 * by verifing that the root directory is at the root of the
>> +	 * by verifying that the root directory is at the root of the
>>  	 * mount namespace which allows all files to be accessed.
>>  	 */
>>  	if (current_chrooted())
>> @@ -617,7 +617,7 @@ static ssize_t map_write(struct file *file, const char __user *buf,
>>  	 *
>>  	 * There is a one time data dependency between reading the
>>  	 * count of the extents and the values of the extents.  The
>> -	 * desired behavior is to see the values of the extents that
>                    ^^^^^^^^ In american englic behavior is a correct spelling.
>                             I don't know why the brits throw in extraneous letters.

and kernel documentation accepts either form of spelling.

>> +	 * desired behaviour is to see the values of the extents that
>>  	 * were written before the count of the extents.
>>  	 *
>>  	 * To achieve this smp_wmb() is used on guarantee the write
>> @@ -716,7 +716,7 @@ static ssize_t map_write(struct file *file, const char __user *buf,
>>  		    (next_line != NULL))
>>  			goto out;
>>  	}
>> -	/* Be very certaint the new map actually exists */
>> +	/* Be very certain the new map actually exists */
>>  	if (new_map.nr_extents == 0)
>>  		goto out;
>>  
>> @@ -841,7 +841,7 @@ static bool new_idmap_permitted(const struct file *file,
>>  
>>  	/* Allow the specified ids if we have the appropriate capability
>>  	 * (CAP_SETUID or CAP_SETGID) over the parent user namespace.
>> -	 * And the opener of the id file also had the approprpiate capability.
>> +	 * And the opener of the id file also had the appropriate capability.
>>  	 */
>>  	if (ns_capable(ns->parent, cap_setid) &&
>>  	    file_ns_capable(file, ns->parent, cap_setid))
> --


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/