linux-kernel - Re: [PATCH] kernel:acct - Fix typos in comment to file header.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5567AEB6.1080203@infradead.org>
Date:	Thu, 28 May 2015 17:11:34 -0700
From:	Randy Dunlap <rdunlap@...radead.org>
To:	Shailendra Verma <shailendra.capricorn@...il.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ionut Alexa <ionut.m.alexa@...il.com>,
	Paul McQuade <paulmcquad@...il.com>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel:acct - Fix typos in comment to file header.

On 05/22/15 22:09, Shailendra Verma wrote:
> Signed-off-by: Shailendra Verma <shailendra.capricorn@...il.com>
> ---
>  kernel/acct.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/kernel/acct.c b/kernel/acct.c
> index 74963d1..fa972fa 100644
> --- a/kernel/acct.c
> +++ b/kernel/acct.c
> @@ -24,8 +24,8 @@
>   *  Now we silently close acct_file on attempt to reopen. Cleaned sys_acct().
>   *  XTerms and EMACS are manifestations of pure evil. 21/10/98, AV.
>   *
> - *  Fixed a nasty interaction with with sys_umount(). If the accointing
> - *  was suspeneded we failed to stop it on umount(). Messy.
> + *  Fixed a nasty interaction with with sys_umount(). If the accounting

You can also drop one of the double "with with" words.

> + *  was suspended we failed to stop it on umount(). Messy.
>   *  Another one: remount to readonly didn't stop accounting.
>   *	Question: what should we do if we have CAP_SYS_ADMIN but not
>   *  CAP_SYS_PACCT? Current code does the following: umount returns -EBUSY
> 


-- 
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/