linux-kernel - Re: [PATCH 5/6] edac, mce_amd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5568B006.9090804@amd.com>
Date:	Fri, 29 May 2015 13:29:26 -0500
From:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To:	Borislav Petkov <bp@...en8.de>
CC:	<dougthompson@...ssion.com>, <mchehab@....samsung.com>,
	<linux-edac@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 5/6] edac, mce_amd_inj: Add README file

On 5/29/2015 10:38 AM, Borislav Petkov wrote:
>
> This one needs to be split in two - the second one adding the readme file...

Ack.

>> +static ssize_t
>> +inj_readme_read(struct file *filp, char __user *ubuf,
>> +		       size_t cnt, loff_t *ppos)
>> +{
>> +	return simple_read_from_buffer(ubuf, cnt, ppos,
>> +					readme_msg, strlen(readme_msg));
>> +}
>> +
>> +static const struct file_operations readme_fops = {
>> +	.read		= inj_readme_read,
>> +};
>> +
>>   static struct dfs_node {
>>   	char *name;
>>   	struct dentry *d;
>>   	const struct file_operations *fops;
>> +	umode_t perm;
>>   } dfs_fls[] = {
>> -	{ .name = "status",	.fops = &status_fops },
>> -	{ .name = "misc",	.fops = &misc_fops },
>> -	{ .name = "addr",	.fops = &addr_fops },
>> -	{ .name = "bank",	.fops = &bank_fops },
>> -	{ .name = "flags",	.fops = &flags_fops },
>> -	{ .name = "cpu",	.fops = &extcpu_fops },
>> +	{ .name = "status",	.fops = &status_fops,	S_IRUSR | S_IWUSR },
>> +	{ .name = "misc",	.fops = &misc_fops,	S_IRUSR | S_IWUSR },
>> +	{ .name = "addr",	.fops = &addr_fops,	S_IRUSR | S_IWUSR },
>> +	{ .name = "bank",	.fops = &bank_fops,	S_IRUSR | S_IWUSR },
>> +	{ .name = "flags",	.fops = &flags_fops,	S_IRUSR | S_IWUSR },
>> +	{ .name = "cpu",	.fops = &extcpu_fops,	S_IRUSR | S_IWUSR },
>> +	{ .name = "README",	.fops = &readme_fops,	S_IRUSR | S_IRGRP |
>> +							S_IROTH },
> ... and the first one adding perm to struct dfs_node.
>

Will do.

Thanks,
-Aravind.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/