linux-kernel - Re: [PATCH 6/6] edac, mce_amd_inj: Inject errors on NBC for bank 4 errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5568B570.5080106@amd.com>
Date:	Fri, 29 May 2015 13:52:32 -0500
From:	Aravind Gopalakrishnan <aravind.gopalakrishnan@....com>
To:	Borislav Petkov <bp@...en8.de>
CC:	<dougthompson@...ssion.com>, <mchehab@....samsung.com>,
	<linux-edac@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 6/6] edac, mce_amd_inj: Inject errors on NBC for bank
 4 errors

On 5/29/2015 11:00 AM, Borislav Petkov wrote:
> On Wed, May 27, 2015 at 02:03:38PM -0500, Aravind Gopalakrishnan wrote:
>>   
>> +static u32 amd_get_num_nodes(void)
>> +{
>> +	u32 nodes = 1;
>> +
>> +	if (cpu_has_topoext) {
>> +		u32 ecx;
>> +
>> +		ecx = cpuid_ecx(0x8000001e);
>> +		nodes = ((ecx >> 8) & 7) + 1;
>> +	} else if (static_cpu_has(X86_FEATURE_NODEID_MSR)) {
>> +		u64 value;
>> +
>> +		rdmsrl(MSR_FAM10H_NODE_ID, value);
>> +		nodes = ((value >> 3) & 7) + 1;
>> +	}
> So we already do that (and more) in amd_get_topology(). I'm thinking
> you should take this function out of the CONFIG_X86_HT ifdeffery (also
> in its caller amd_detect_cmp()) and you should save "nodes" in a local
> static variable called nodes_per_processor and a small accessor called
> amd_get_nodes_cnt() should return it. Similar to amd_get_nb_id().

  I can remove the #ifdefs, but I'm wondering why it was there to begin 
with..
CONFIG_X86_HT defaults to 'Y' anyway right?

And OK, will add the function in a separate pre-patch.

> Don't forget to add a comment explaning what that nodes_per_processor
> means.

Will do.

> And then amd_mce_inj.c will simply use it instead of duplicating that
> information here.
>
> Please do that in 2 pre-patches.

Will do.

>> +
>> +	if (!(val & BIT(27))) {
>> +		pr_err("%s: BIOS not setting D18F3x44[NbMcaToMstCpuEn]."
>> +		       "Doing that here\n", __func__);
> WARNING: quoted string split across lines
> #99: FILE: drivers/edac/mce_amd_inj.c:260:
> +               pr_err("%s: BIOS not setting D18F3x44[NbMcaToMstCpuEn]."
> +                      "Doing that here\n", __func__);
>
> Do integrate checkpatch.pl into your workflow. It is sometimes right.

Yeah, I do run checkpatch. With this, I think the line was going above 
79 chars. So split it.
I thought we split such error messages right?
(amd64_edac and mce_amd.c for example have such instances)


Thanks,
-Aravind.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/