linux-kernel - Re: [PATCH v2 00/13] SMM implementation for KVM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5568BF28.3040806@redhat.com>
Date:	Fri, 29 May 2015 21:34:00 +0200
From:	Paolo Bonzini <pbonzini@...hat.com>
To:	Radim Krčmář <rkrcmar@...hat.com>
CC:	linux-kernel@...r.kernel.org, kvm@...r.kernel.org,
	guangrong.xiao@...ux.intel.com, bdas@...hat.com
Subject: Re: [PATCH v2 00/13] SMM implementation for KVM



On 29/05/2015 21:03, Radim Krčmář wrote:
> I found a corner case that doesn't fit any specific patch:
> 
> We allow INIT while in SMM.  This brings some security complications as
> we also don't reset hflags (another long standing bug?), but we don't
> really need to because INIT in SMM is against the spec anyway;
> APM May 2013 2:10.3.3 Exceptions and Interrupts,
>   • INIT—The processor does not recognize INIT while in SMM.
> 
> SDM April 2015: 34.5.1  Initial SMM Execution Environment,
>   Maskable hardware interrupts, exceptions, NMI interrupts, SMI
>   interrupts, A20M interrupts, single-step traps, breakpoint traps, and
>   INIT operations are inhibited when the processor enters SMM.
> 
> And there is no mention of an exception for INIT.
> (Some extra old experiments say that INIT could be enabled, but that is
>  not applicable now,  http://www.rcollins.org/ddj/Mar97/Mar97.html)
> 
> I think that INIT received before RSM should be delivered after.

Yes.  I'll look at it next week and post a 14th patch.

Paolo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/