linux-kernel - Re: [PATCH v2] security_syslog() should be called once only

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5569C066.1010300@virtuozzo.com>
Date:	Sat, 30 May 2015 16:51:34 +0300
From:	Vasily Averin <vvs@...tuozzo.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, Kees Cook <keescook@...omium.org>,
	Josh Boyer <jwboyer@...hat.com>, Eric Paris <eparis@...hat.com>
Subject: Re: [PATCH v2] security_syslog() should be called once only

On 28.05.2015 02:43, Andrew Morton wrote:
> So we run security_syslog() for actions other than open() (of kmsg). 
> Why?
Could you please clarify this question?

Linux kernel have reasonable default security policy and it's great.
And at the same time kernel allows to override default behaviour
and set custom security policy.
For example, to prohibit work on Saturday.
QA can use it for random failures generation.
Why not?

> Also, that from_file handling makes me cry.
...
> One possible fix would be something like this, plus various
> fixups/audit:

I've prepared such patch and send it in separate letter.

> And `type' should be renamed to `action' for heavens sake.

IMHO 'type' and SYSLOG_ACTION_* was inherited from sys_syslog definition.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/