linux-kernel - Re: [PATCH] usb: isp1760: fix null dereference if kzalloc returns null

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 01 Jun 2015 01:15:24 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Colin King <colin.king@...onical.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Laurent Pinchart <laurent.pinchart@...asonboard.com>,
	Felipe Balbi <balbi@...com>,
	Sudeep Holla <sudeep.holla@....com>, linux-usb@...r.kernel.org
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] usb: isp1760: fix null dereference if kzalloc returns
 null

Hello.

On 06/01/2015 01:00 AM, Colin King wrote:

> From: Colin Ian King <colin.king@...onical.com>

> If kzalloc returns null then isp1760_ep_alloc_request performs
> a null pointer deference on req.

    Dereference, not "deference".
    No, it doesn't. It calculates the address of the 'isp1760_request::req' 
instead, there's no dereference per se. I suppose this is a first member of 
the structure, so this function should work correctly in any case.

> Check for null to avoid this.

> Detected with smatch static analysis:
>
> drivers/usb/isp1760/isp1760-udc.c:816 isp1760_ep_alloc_request()
>    error: potential null dereference 'req'.  (kzalloc returns null)

    Well, the change won't hurt anyway, makes things clearer.

> Signed-off-by: Colin Ian King <colin.king@...onical.com>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/