linux-kernel - Re: [PATCH RESEND] staging: rtl8192u: ieee80211: Fix sparse endianness warnings

Open Source and information security mailing list archives

Message-ID: <20150531221739.GA28024@kroah.com>
Date:	Mon, 1 Jun 2015 07:17:39 +0900
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Gaston Gonzalez <gascoar@...il.com>
Cc:	cristina.opriceana@...il.com, hamohammed.sa@...il.com,
	gdonald@...il.com, mahfouz.saif.elyazal@...il.com,
	paul.gortmaker@...driver.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH RESEND] staging: rtl8192u: ieee80211: Fix sparse
 endianness warnings

On Sun, May 31, 2015 at 12:17:48PM -0300, Gaston Gonzalez wrote:
> Fix the following sparse warnings:
> 
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32: warning: incorrect type in assignment (different base types)
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32:    expected restricted __le16 [usertype] frame_ctl
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:663:32:    got int
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:664:50: warning: invalid assignment: |=
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:664:50:    left side has type restricted __le16
> drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c:664:50:    right side has type int
> 
> 
> Signed-off-by: Gaston Gonzalez <gascoar@...il.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Still doesn't apply, but this might be a git bug, see below:

> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> index d2e8b12..0477ba1 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
> @@ -660,2 +660,2 @@ inline struct sk_buff *ieee80211_authentication_req(struct ieee80211_network *be
>  	auth = (struct ieee80211_authentication *)
>  		skb_put(skb, sizeof(struct ieee80211_authentication));
> 
> -	auth->header.frame_ctl = IEEE80211_STYPE_AUTH;
> -	if (challengelen) auth->header.frame_ctl |= IEEE80211_FCTL_WEP;
> +	auth->header.frame_ctl = cpu_to_le16(IEEE80211_STYPE_AUTH);
> +	if (challengelen)
> +		auth->header.frame_ctl |= cpu_to_le16(IEEE80211_FCTL_WEP);
> 
>  	auth->header.duration_id = 0x013a; //FIXME
> 
> --
> 2.1.4

This patch is not created properly.  Did you edit it by hand?  If not,
we need to report a bug as the diff is obviously wrong, look at the @@@
line.

Can you update your version of git to see if it's fixed there?

Also, patch tells you that this is broken:

checking file drivers/staging/rtl8192u/ieee80211/ieee80211_softmac.c
patch: **** malformed patch at line 132:                skb_put(skb, sizeof(struct ieee80211_authentication));

> 
> _______________________________________________
> devel mailing list
> devel@...uxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives