linux-kernel - Re: [PATCH 2/3 v3] Staging: rtl8192u: Remove two useless lines at ieee80211_wep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20150531013719.GD28154@kroah.com>
Date:	Sun, 31 May 2015 10:37:19 +0900
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Pedro Marzo Perez <marzo.pedro@...il.com>
Cc:	navyasri.tech@...il.com, dilekuzulmez@...il.com, joe@...ches.com,
	haticeerturk27@...il.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3 v3] Staging: rtl8192u: Remove two useless lines at
 ieee80211_wep_null

On Tue, May 19, 2015 at 01:32:23AM +0200, Pedro Marzo Perez wrote:
> Removed two lines at ieee80211_wep_null which checkpatch.pl reported as errors.
> The first one because it has a C99 comment style and the second one because it is a void
> return which is useless.
> 
> Signed-off-by: Pedro Marzo Perez <marzo.pedro@...il.com>
> ---
>  drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> index 388ed3c..2ce7b54 100644
> --- a/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> +++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_crypt_wep.c
> @@ -289,6 +289,4 @@ void __exit ieee80211_crypto_wep_exit(void)
>  
>  void ieee80211_wep_null(void)
>  {
> -//	printk("============>%s()\n", __func__);
> -	return;
>  }

You now have a function that does nothing, why not just delete it
entirely?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/