linux-kernel - Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150531013818.GE28154@kroah.com>
Date:	Sun, 31 May 2015 10:38:18 +0900
From:	"gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>
To:	"Dhere, Chaitanya (C.)" <cvijaydh@...teon.com>
Cc:	"cristina.opriceana@...il.com" <cristina.opriceana@...il.com>,
	"hamohammed.sa@...il.com" <hamohammed.sa@...il.com>,
	"gdonald@...il.com" <gdonald@...il.com>,
	"mahfouz.saif.elyazal@...il.com" <mahfouz.saif.elyazal@...il.com>,
	"benoit.taine@...6.fr" <benoit.taine@...6.fr>,
	"paul.gortmaker@...driver.com" <paul.gortmaker@...driver.com>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] staging: rtl8192u: Patch to modify if, else conditions

On Tue, May 19, 2015 at 04:55:57PM +0000, Dhere, Chaitanya (C.) wrote:
> In this patch:
> 1. the if condition is modified to remove
> the unnecessary equality check.
> 2. The else if condition is replaced by an else condition
> since the variable checked in the if statement is a bool
> making the else if unnecessary.
> 3. Fixed indentation problem on line 1369.
> These changes were detected with help of coccinelle tool.

3 different things means you need to send 3 different patches.  Please
only do one logical thing per patch.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/