linux-kernel - Re: [PATCH v7 1/4] ASoC: arizona: Export functions to control subsystem DVFS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 1 Jun 2015 17:36:04 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Richard Fitzgerald <rf@...nsource.wolfsonmicro.com>
Cc:	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org, lgirdwood@...il.com
Subject: Re: [PATCH v7 1/4] ASoC: arizona: Export functions to control
 subsystem DVFS

On Mon, Jun 01, 2015 at 05:22:51PM +0100, Richard Fitzgerald wrote:
> On Mon, Jun 01, 2015 at 05:10:47PM +0100, Mark Brown wrote:

> > > +		if (priv->dvfs_reqs)
> > > +			ret = arizona_dvfs_disable(codec);

> > Are you sure that the function shouldn't check for requests?  It seems
> > like every caller is repeating the same check.

> Sorry, I don't understand your comment here. When SYSCLK is disabled
> we need to disable DVFS so that the codec can't go into suspend in the
> illegal state of DVFS enabled but insifficient DCVDD. However, if
> dvfs_reqs==0 DVFS is already disabled so we can save some time.

Sure, but you repeat the same tests for dvfs_reqs at every call site
which suggests it should be factored into the functions.

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)