linux-kernel - Re: [patch 4/7] timer: Replace timer base by a cpu index

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1506021452000.3786@nanos>
Date:	Tue, 2 Jun 2015 15:58:48 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Peter Zijlstra <peterz@...radead.org>
cc:	Viresh Kumar <viresh.kumar@...aro.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Eric Dumazet <edumazet@...gle.com>,
	John Stultz <john.stultz@...aro.org>,
	Joonwoo Park <joonwoop@...eaurora.org>,
	Wenbo Wang <wenbo.wang@...blaze.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Badhri Jagan Sridharan <Badhri@...gle.com>
Subject: Re: [patch 4/7] timer: Replace timer base by a cpu index

On Wed, 27 May 2015, Peter Zijlstra wrote:

> On Wed, May 27, 2015 at 02:52:36PM +0530, Viresh Kumar wrote:
> > > +		timer->flags = (timer->flags & ~TIMER_BASEMASK) | cpu;
> > 
> > Because 'cpu' is used only once in this routine, maybe we can use
> > 'new_base->cpu' here and the line will still be exactly 80 columns
> > long.
> > 
> > Not sure, but maybe we can create a inline helper for this operation
> > as it is repeated at multiple places.
> 
> I suggested bitfields at some point I think. That gets the compiler to
> generate those helpers for you.

I tried, but they are a PITA for the static initializiers and I could
not be bothered to deal with the endianess mess. Maybe I should try
again :)

Thanks,

	tglx





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/