linux-kernel - Re: [PATCH v4 00/25] Convert the posix_clock_operations and k

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.11.1506022115240.20347@nanos>
Date:	Tue, 2 Jun 2015 21:20:45 +0200 (CEST)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Baolin Wang <baolin.wang@...aro.org>
cc:	arnd@...db.de, john.stultz@...aro.org, heenasirwani@...il.com,
	pang.xunlei@...aro.org, peterz@...radead.org,
	rafael.j.wysocki@...el.com, gregkh@...uxfoundation.org,
	richardcochran@...il.com, benh@...nel.crashing.org,
	paulus@...ba.org, mpe@...erman.id.au, schwidefsky@...ibm.com,
	heiko.carstens@...ibm.com, linux390@...ibm.com, rth@...ddle.net,
	riel@...hat.com, cl@...ux.com, tj@...nel.org, fweisbec@...il.com,
	ahh@...gle.com, pjt@...gle.com, linuxppc-dev@...ts.ozlabs.org,
	linux-s390@...r.kernel.org, linux-arch@...r.kernel.org,
	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	serge.hallyn@...onical.com, james.l.morris@...cle.com,
	serge@...lyn.com, pmoore@...hat.com, tiwai@...e.de,
	jeffv@...gle.com, jlayton@...marydata.com, keescook@...omium.org,
	sds@...ho.nsa.gov, mark.d.rustad@...el.com,
	linux-security-module@...r.kernel.org, y2038@...ts.linaro.org
Subject: Re: [PATCH v4 00/25] Convert the posix_clock_operations and k_clock
 structure to ready for 2038

On Mon, 1 Jun 2015, Baolin Wang wrote:

> This patch series changes the 32-bit time types (timespec/itimerspec) to
> the 64-bit types (timespec64/itimerspec64), since 32-bit time types will
> break in the year 2038.

That's only true for 32bit systems.

All in all the patch series looks rather reasonable now, except for
the subject lines and the changelogs.

The only technical objection I have is the macro conversion magic in
patch #6. This can be done in a less cryptic and more efficient way.

See the comments to the various patches and please apply them to all
of the series.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/