linux-kernel - Re: [PATCH 3.14 10/64] xfs: xfs_iozero can return positive errno

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20150603131551.GD1737@ares>
Date:	Wed, 3 Jun 2015 14:15:51 +0100
From:	Luis Henriques <luis.henriques@...onical.com>
To:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Dave Chinner <dchinner@...hat.com>,
	Brian Foster <bfoster@...hat.com>,
	Dave Chinner <david@...morbit.com>
Subject: Re: [PATCH 3.14 10/64] xfs: xfs_iozero can return positive errno

On Wed, Jun 03, 2015 at 08:42:38PM +0900, Greg Kroah-Hartman wrote:
> 3.14-stable review patch.  If anyone has any objections, please let me know.
> 

I guess you forgot to drop this patch.

Cheers,
--
Luís

> ------------------
> 
> From: Dave Chinner <dchinner@...hat.com>
> 
> commit cddc116228cb9d51d3224d23ba3e61fbbc3ec3d2 upstream.
> 
> It was missed when we converted everything in XFs to use negative error
> numbers, so fix it now. Bug introduced in 3.17 by commit 2451337 ("xfs: global
> error sign conversion"), and should go back to stable kernels.
> 
> Thanks to Brian Foster for noticing it.
> 
> Signed-off-by: Dave Chinner <dchinner@...hat.com>
> Reviewed-by: Brian Foster <bfoster@...hat.com>
> Signed-off-by: Dave Chinner <david@...morbit.com>
> Signed-off-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> 
> ---
>  fs/xfs/xfs_file.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/fs/xfs/xfs_file.c
> +++ b/fs/xfs/xfs_file.c
> @@ -126,7 +126,7 @@ xfs_iozero(
>  		status = 0;
>  	} while (count);
>  
> -	return (-status);
> +	return status;
>  }
>  
>  /*
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe stable" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/